pillar/volumemgr: Kick watchdog inside for loops #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3596 +/- ##
==========================================
- Coverage 19.42% 19.42% -0.01%
==========================================
Files 232 232
Lines 50508 50515 +7
==========================================
+ Hits 9812 9813 +1
- Misses 39976 39981 +5
- Partials 720 721 +1 ☔ View full report in Codecov by Sentry. |
createOrUpdateDiskMetrics() has a lot of for loops that can take more than the watchdog time (500s) to execute. This commit adds some kicks to the watchdog inside these loops. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
|
Updates in this PR:
|
milan-zededa
approved these changes
Nov 20, 2023
This was referenced Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createOrUpdateDiskMetrics() has a lot of for loops that can take more than the watchdog time (500s) to execute. This commit adds some kicks to the watchdog inside the for loops.